-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching symbols on symbol resolution #1334
Conversation
5254d7a
to
28e2b4d
Compare
fa416fd
to
f83c602
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Maybe provide some tests to make sure corner cases like variable shadowing work as expected?
Good idea. One caveat though: variable shadowing is not really supported even without caching :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8ea5130
to
2d8fd78
Compare
2d8fd78
to
cdc33d9
Compare
This PR caches symbol resolutions. This can can significantly speed up the resolution process.
…aryOperation` (#1333) Support for `<<`, `>>` and `|` in `ValueEvaluator` and `BinaryOperation`
cdc33d9
to
ee1c7aa
Compare
Kudos, SonarCloud Quality Gate passed! |
This PR caches symbol resolutions. This can can significantly speed up the resolution process.