Introduce simpleAssignmentOperators in Language
#1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
fixing-go-data-flows
branch
2 times, most recently
from
8a49957
to
7241451
Compare
oxisto
changed the title
simpleAssignmentOperators in Language
oxisto
force-pushed
the
fixing-go-data-flows
branch
2 times, most recently
from
7f33d0c
to
a3969ea
Compare
oxisto
force-pushed
the
fixing-go-data-flows
branch
from
a3969ea
to
68e8098
Compare
|
konradweiss
approved these changes
Mar 15, 2024
KuechA
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
simpleAssignmentOperatorsproperty inLanguage, which for most languages will only be=. But for some languages, such as Go, we need to extend this also to:=. Therefore, this PR fixes several issues with Go data-flows. Mostly related to bugs in the assignment expression translation.Fixes #1461
Fixes #1462
Fixes #1463