Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kw/backward ast #1628

Open
wants to merge 7 commits into
base: mk/backwards-ast
Choose a base branch
from
Open

Kw/backward ast #1628

wants to merge 7 commits into from

Conversation

konradweiss
Copy link
Collaborator

@konradweiss konradweiss commented Jul 22, 2024 •
edited
Loading

This PR adapts the CXX and Java frontend to the .withChildren pattern. In this version the assumption is still that withChildren implements the functionality of the AST parent check and some syntax may have to be changed before merging all into main.

@konradweiss konradweiss changed the base branch from main to mk/backwards-ast July 22, 2024 14:26
@konradweiss konradweiss marked this pull request as ready for review August 6, 2024 12:39
@KuechA
Copy link
Contributor

KuechA commented Sep 1, 2024

I guess this PR is obsoleted by #1646 and #1642 and should be closed?

@maximiliankaul
Copy link
Contributor

I guess this PR is obsoleted by #1646 and #1642 and should be closed?

No, we want to include this work once the withChildren { ... } (or similar) stuff is merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckto peckto Awaiting requested review from peckto peckto is a code owner

@oxisto oxisto Awaiting requested review from oxisto oxisto is a code owner

@KuechA KuechA Awaiting requested review from KuechA KuechA is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konradweiss @KuechA @maximiliankaul