Improve the Pass system #1645
Merged
Improve the Pass system #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d support "soft" ExecuteBefore depndencies.
maximiliankaul
requested review from
konradweiss,
oxisto and
KuechA
as code owners
oxisto
reviewed
Sep 4, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/TranslationConfiguration.kt
Show resolved
Hide resolved
maximiliankaul
commented
Sep 4, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/TranslationConfiguration.kt
Outdated
Show resolved
Hide resolved
oxisto
reviewed
Sep 4, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/MermaidHelper.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/MermaidHelper.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/MermaidHelper.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/MermaidHelper.kt
Outdated
Show resolved
Hide resolved
oxisto
approved these changes
Sep 4, 2024
|
maximiliankaul
added a commit
that referenced
this pull request
Sep 5, 2024
oxisto
pushed a commit
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the pass ordering system. It removes some logic bugs and tries to keep a strict separation between files (TranslationConfiguration does not do the ordering logic, ...)
New features:
ExecuteLateannotation.ExecuteBeforenow hassoft/harddependencies.Passes (theirKClass) can now be queried forisFirstPass,softDependencies, ...Fixes #1641
Todo;
workingListsoft/hardforExecuteBeforeas requested by @KuechA