Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TODO() with ProblemDeclaration nodes #1663

Merged
merged 16 commits into from
Sep 6, 2024
Merged

Replace TODO() with ProblemDeclaration nodes #1663

merged 16 commits into from
Sep 6, 2024

Conversation

maximiliankaul
Copy link
Contributor

@maximiliankaul maximiliankaul commented Aug 27, 2024 •
edited
Loading

  • Change to Node: add addtionalProblems field.
  • Replace TODOs with ProblemDeclarations.

@maximiliankaul maximiliankaul marked this pull request as ready for review September 5, 2024 12:32
@maximiliankaul maximiliankaul self-assigned this Sep 5, 2024
@maximiliankaul
Copy link
Contributor Author

@oxisto I'm a bit unhappy with the problems being attached to the TU instead of where they should be. Any suggestions to improve upon this situation?

@maximiliankaul maximiliankaul enabled auto-merge (squash) September 6, 2024 07:52
oxisto
oxisto approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@oxisto oxisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Since this changes node properties... Maybe a second opinion @konradweiss @KuechA

@maximiliankaul maximiliankaul mentioned this pull request Sep 6, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
29.4% Coverage on New Code (required ≥ 75%)

See analysis details on SonarCloud

@KuechA
Copy link
Contributor

KuechA commented Sep 6, 2024

Looks good to me. Since this changes node properties... Maybe a second opinion @konradweiss @KuechA

I'm also fine with the changes but we should fix the comment above

@oxisto oxisto mentioned this pull request Sep 6, 2024
Open
@oxisto oxisto merged commit 448ab2d into main Sep 6, 2024
2 of 3 checks passed
@oxisto oxisto deleted the mk/pythonTodo2Problem branch September 6, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxisto oxisto oxisto approved these changes

@konradweiss konradweiss Awaiting requested review from konradweiss konradweiss is a code owner

@KuechA KuechA Awaiting requested review from KuechA KuechA is a code owner

Assignees

@maximiliankaul maximiliankaul

Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximiliankaul @KuechA @oxisto