Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoolOp as loop instead of recursion #1700

Closed
wants to merge 11 commits into from
Closed

BoolOp as loop instead of recursion #1700

wants to merge 11 commits into from

Conversation

maximiliankaul
Copy link
Contributor

No description provided.

@maximiliankaul maximiliankaul mentioned this pull request Sep 20, 2024
Merged
oxisto
oxisto reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@oxisto oxisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to avoid recursion here, only minor fixes

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oxisto
Copy link
Member

oxisto commented Sep 23, 2024

We will take the solution in #1698

@oxisto oxisto closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxisto oxisto oxisto left review comments

@KuechA KuechA Awaiting requested review from KuechA

@lshala lshala Awaiting requested review from lshala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximiliankaul @oxisto @KuechA