Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python type hints #1701

Merged
merged 11 commits into from
Sep 25, 2024
Merged

Support python type hints #1701

merged 11 commits into from
Sep 25, 2024

Conversation

lshala
Copy link
Contributor

@lshala lshala commented Sep 20, 2024

This PR aims to support python type hints, particularly type_comments and type annotation.

Fixes #1649
Fixes #1656
Fixes #1655

@lshala lshala linked an issue Sep 20, 2024 that may be closed by this pull request
@lshala lshala marked this pull request as ready for review September 20, 2024 14:00
Copy link
Contributor

@maximiliankaul maximiliankaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@oxisto oxisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok for now. I added a comment to #1602 (comment) about the assignment with no RHS.

@oxisto oxisto enabled auto-merge (squash) September 25, 2024 11:49
Copy link

sonarcloud bot commented Sep 25, 2024

@oxisto oxisto merged commit 13f82d4 into main Sep 25, 2024
3 checks passed
@oxisto oxisto deleted the ls/1655-support-python-type-annotation branch September 25, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support type annotation on AnnAssign PEP-484: Support all python type hints Python type_comments
3 participants