Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle delete statement in python frontend #1723

Merged
merged 10 commits into from
Sep 25, 2024
Merged

Handle delete statement in python frontend #1723

merged 10 commits into from
Sep 25, 2024

Conversation

lshala
Copy link
Contributor

@lshala lshala commented Sep 24, 2024 •
edited
Loading

This PR adds support for handling delete statements in Python.
Fixes #1709

@lshala lshala linked an issue Sep 24, 2024 that may be closed by this pull request
Python frontend: Handle delete statement #1709
Closed
@lshala lshala added the python label Sep 24, 2024
@lshala lshala marked this pull request as ready for review September 24, 2024 13:51
@lshala lshala requested a review from peckto as a code owner September 25, 2024 08:45
oxisto
oxisto approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@oxisto oxisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can ignore the test coverage here because it was because of missing C++ coverage

@oxisto @maximiliankaul
Update cpg-language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/fr…
487ee06 
…ontends/python/StatementHandler.kt

Co-authored-by: Maximilian Kaul <[email protected]>
@oxisto oxisto enabled auto-merge (squash) September 25, 2024 15:44
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
70.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarCloud

@oxisto oxisto merged commit 1fced84 into main Sep 25, 2024
2 of 3 checks passed
@oxisto oxisto deleted the ls/1709-handle-delete-statement-in-python-frontend branch September 25, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankaul maximiliankaul maximiliankaul left review comments

@oxisto oxisto oxisto approved these changes

@konradweiss konradweiss Awaiting requested review from konradweiss konradweiss is a code owner

@KuechA KuechA Awaiting requested review from KuechA KuechA is a code owner

@peckto peckto Awaiting requested review from peckto peckto is a code owner

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python frontend: Handle delete statement
3 participants
@lshala @oxisto @maximiliankaul