Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kotlin to 2.0.20 #1727

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Bump Kotlin to 2.0.20 #1727

merged 2 commits into from
Sep 25, 2024

Conversation

maximiliankaul
Copy link
Contributor

No description provided.

@oxisto
Copy link
Member

oxisto commented Sep 25, 2024

Should we add the experimental UUID to the compiler options as well? It is specified in cpg.common-conventions.gradle:

freeCompilerArgs = listOf("-opt-in=kotlin.RequiresOptIn", "-opt-in=kotlin.uuid.ExperimentalUuidApi", "-Xcontext-receivers")

should do the trick

@maximiliankaul
Copy link
Contributor Author

Should we add the experimental UUID to the compiler options as well? It is specified in cpg.common-conventions.gradle:

freeCompilerArgs = listOf("-opt-in=kotlin.RequiresOptIn", "-opt-in=kotlin.uuid.ExperimentalUuidApi", "-Xcontext-receivers")

should do the trick

I currently annotate the function I'm using UUID in.
Both works for me.

@oxisto
Copy link
Member

oxisto commented Sep 25, 2024

Should we add the experimental UUID to the compiler options as well? It is specified in cpg.common-conventions.gradle:

freeCompilerArgs = listOf("-opt-in=kotlin.RequiresOptIn", "-opt-in=kotlin.uuid.ExperimentalUuidApi", "-Xcontext-receivers")

should do the trick

I currently annotate the function I'm using UUID in. Both works for me.

I would prefer the opt-in compiler flag, then I can also replace the other code where I am currently using the java UUID.

@maximiliankaul
Copy link
Contributor Author

maximiliankaul commented Sep 25, 2024

Should we add the experimental UUID to the compiler options as well? It is specified in cpg.common-conventions.gradle:

freeCompilerArgs = listOf("-opt-in=kotlin.RequiresOptIn", "-opt-in=kotlin.uuid.ExperimentalUuidApi", "-Xcontext-receivers")

should do the trick

I currently annotate the function I'm using UUID in. Both works for me.

I would prefer the opt-in compiler flag, then I can also replace the other code where I am currently using the java UUID.

I'll add this to #1728 -> done ✔️

@oxisto oxisto enabled auto-merge (squash) September 25, 2024 11:32
Copy link

sonarcloud bot commented Sep 25, 2024

@oxisto oxisto merged commit d6e6e2c into main Sep 25, 2024
3 checks passed
@oxisto oxisto deleted the mk/kotlin_2_0_20 branch September 25, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants