Implemented base class for ExceptHandler
#1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
changed the title
ExceptHandler
oxisto
force-pushed
the
excepthandler
branch
from
5615494
to
b9dc976
Compare
oxisto
force-pushed
the
excepthandler
branch
from
8038ee1
to
c2446c3
Compare
|
Co-Authored-By: Maximilan Kaul <[email protected]>
oxisto
force-pushed
the
excepthandler
branch
from
6c82424
to
34a1faa
Compare
|
Please double-check @maximiliankaul, test coverage will be 0 % until we merge in the other PR so we can ignore the test coverage for now. |
maximiliankaul
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a TODO we had in the code, where our class
excepthandlerwas both the base "interface" as well as the concrete AST node. This splits up both, similar toast.stmtand other cases.