Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UnaryOperator used as throw from EOG pass and spec #1819

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

KuechA
Copy link
Contributor

@KuechA KuechA commented Nov 6, 2024

Currently, the EvaluationOrderGraphPass handles the UnaryOperator with operatorCode "throw" as a throw expression. Since all frontends have been migrated to use the ThrowExpression, this is obsolete. The eog-spec-file is updated and the pass too.

Closes #1817

@KuechA KuechA added the graph-changing This change breaks the current graph structure, i.e. it changes semantic of properties and edges label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.24%. Comparing base (692023f) to head (5ef8714).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hofer/aisec/cpg/passes/EvaluationOrderGraphPass.kt 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...hofer/aisec/cpg/passes/EvaluationOrderGraphPass.kt 89.59% <84.21%> (+0.29%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KuechA KuechA enabled auto-merge (squash) November 6, 2024 09:16
@KuechA KuechA merged commit 4e7c0b8 into main Nov 6, 2024
3 checks passed
@KuechA KuechA deleted the ak/remove-throw-unaryop branch November 6, 2024 09:20
lshala pushed a commit that referenced this pull request Nov 8, 2024
* Remove UnaryOperator used as throw from EOG pass and spec

* Add the unspecificUnaryOperator method again for Go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graph-changing This change breaks the current graph structure, i.e. it changes semantic of properties and edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace UnaryOperator "throw" with new ThrowStatement
2 participants