-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A lot about logging... #434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdinandjarisch
requested review from
peckto and
fkglr
and removed request for
peckto and
fkglr
September 15, 2023 15:59
ferdinandjarisch
force-pushed
the
mr-log
branch
from
September 15, 2023 16:13
8b4ef77
to
f571042
Compare
Your stuff is merged. You could do your rebase! Thx for your efforts. 🎊 |
ferdinandjarisch
force-pushed
the
mr-log
branch
from
September 18, 2023 15:51
f571042
to
8726073
Compare
rumpelsepp
reviewed
Sep 26, 2023
ferdinandjarisch
force-pushed
the
mr-log
branch
from
September 26, 2023 17:40
ae63d54
to
7654f47
Compare
This switch disables the introduced default behaviour of overwriting all log lines with INFO or lower on the terminal output.
This will clutter terminal logs, but this is what we have --volatile-info for. File-based logs are DEBUG anyhow.
ferdinandjarisch
force-pushed
the
mr-log
branch
from
September 27, 2023 07:12
9734c32
to
781c4be
Compare
ferdinandjarisch
requested review from
rumpelsepp
and removed request for
peckto
September 27, 2023 07:13
@rumpelsepp It reached its final form |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.