fix: Remove auto-discovery of sessions from multiple scanners #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have a dedicated scanner for identifying available sessions it does not make sense to implement a low-effort variant of sessions-scanning for multiple scanners with totally different tasks. Moreover, this change allows to run these scanners without requiring the availability of DiagnosticSessionControl, as long as no --sessions flag is given.
mich41v4294
added a commit
to mich41v4294/gallia
that referenced
this pull request
Apr 19, 2024
fixed arg help after PR Fraunhofer-AISEC#457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have a dedicated scanner for identifying available sessions it does not make sense to implement a low-effort variant of sessions-scanning for multiple scanners with totally different tasks.
Moreover, this change allows to run these scanners without requiring the availability of DiagnosticSessionControl, as long as no --sessions flag is given.