Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Version 14 of Postgres #12

Open
wants to merge 1 commit into
base: Add_flexible_servers
Choose a base branch
from

Conversation

timway
Copy link

@timway timway commented Jun 30, 2023

  • Add version 14 to the list of choices for versions
  • Docs clean-ups in azure_rm_postgresqlflexibleserver

* Add version 14 to the list of choices for Postgres SQL versions
* Remove extraneous quotation in YAML
* Keep quotation marks consistent (sample)
* YAML boolean "true" (True is valid but more consistent to be lowercase as found in yamllint)
@timway timway changed the title Rebase and Allow Version 14 of Postgres Allow Version 14 of Postgres Jun 30, 2023
@timway
Copy link
Author

timway commented Jul 13, 2023

@Fred-sun just checking in, can we add this in?

@Fred-sun
Copy link
Owner

Fred-sun commented Jul 13, 2023 via email

@timway
Copy link
Author

timway commented Jul 13, 2023

@Fred-sun I sent it to your branch so it's included in the PR for this feature.

@Fred-sun
Copy link
Owner

Fred-sun commented Jul 14, 2023 via email

@timway
Copy link
Author

timway commented Jul 15, 2023

@Fred-sun two interesting things, it works on the ansible side as is and creates a version 14 database and version 14 support is available starting in azure-mgmt-rdbms==10.2.0b2. I'm not sure when 10.2.0 will come out and we'd of course have to test the rest of the code against the newer version.

https://github.com/Azure/azure-sdk-for-python/blame/781428fce7758ec1f1d08db336f9c2d1313c1ac8/sdk/rdbms/azure-mgmt-rdbms/azure/mgmt/rdbms/postgresql_flexibleservers/models/_postgre_sql_management_client_enums.py#L343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants