-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding array operations unit test WDL #25
Conversation
@tefirman this looks great! Wondering if we should add tests that specifically evaluate:
Just some thoughts... feel free to comment on if all or some of these will be useful! |
@sitapriyamoorthi -- Great call. I added a few more tasks to implement your suggestions:
Not super worried about empty arrays, but I did run it with an empty array and it seems to work fine. Mind taking another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tefirman thanks for including those changes. Just a couple of things that would complete this unit test :
- Could you add to test an array of integers (just so we complete the circle). And test that the integers are properly parsed (my assumption is something simple like addition of integers would test that)
- Could you also add something that tests the intermediate declaration of an array of integers similar to what you have done for strings.
- Could you also add a small part to test that an array of files are properly localized and can be correctly indexed.
Thanks!
@sitapriyamoorthi -- added a few updates to address your suggestions:
Mind taking another look? |
Been reviewing it... will add my comments shortly.. |
Updating the Readme with small changes to make things a bit more clear
Adding comments for clarity.
Array unit test smoorthi
@sitapriyamoorthi -- Merged in your PR if you wanted to take another look. |
Looks good! @tefirman |
@tefirman I am holding back from squashing and merging just yet since technically I have not successfully got this to run on PROOF. Starting a thread on the proof channel to discuss this. My thoughts are that since it runs locally on miniwdl. The WDL itself works on a WDL runner but may or may not run on PROOF. Lets chat more there before merging. |
@sitapriyamoorthi -- Just confirmed that this WDL runs successfully in the proof-api-dev branch, so I'm going to merge this into main. |
Description
Related Issues
Testing