Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initial version of nonstandard outputs WDL unit test #60

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tefirman
Copy link
Collaborator

@tefirman tefirman commented Jan 15, 2025

Description

  • Adding a workflow that demonstrates the usage of non-standard outputs such as globs, symlinks, and strange filenames/extensions.

Related Issues

Testing

  • Ran locally via miniwdl, completes successfully.

@tefirman tefirman added the unit test Adding or modifying a unit test label Jan 15, 2025
@sitapriyamoorthi
Copy link
Collaborator

while i understand that glob is being test here i would recommend removing the link to the issue because i have abranch that tests all that needs to be tested for globbing and i would like to link that issue with that branch. thanks.

Copy link
Collaborator

@sitapriyamoorthi sitapriyamoorthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove issue link to glob to make sure we are addressing all glob testing in the different branch. WDL looks great and is testing everything that needs to be tested.

@sitapriyamoorthi
Copy link
Collaborator

Tested on PROOF prod. WDL Workflow fails due to docker error:

FATAL: While making image from oci registry: error fetching image to cache: failed to get checksum for docker://ubuntu:noble-20241118.1@sha256:80dd3c3b9c6cecb9f1667e9290b3bc61b78c2678c02cbdae5f0fea92cc6734ab: unable to parse image name docker://ubuntu:noble-20241118.1@sha256:80dd3c3b9c6cecb9f1667e9290b3bc61b78c2678c02cbdae5f0fea92cc6734ab: Docker references with both a tag and digest are currently not supported

@tefirman tefirman mentioned this pull request Jan 15, 2025
@tefirman
Copy link
Collaborator Author

Weird, I'm seeing the same thing on my end, but only with Apptainer, not with Docker. Let me remove the sha tag, we should be specific, but maybe don't have to be that specific...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit test Adding or modifying a unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task output symlink usage Non-standard output format
2 participants