Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to R package #40

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Conversation

xec-cm
Copy link

@xec-cm xec-cm commented Jan 28, 2022

Hi @FrederickHuangLin,

First congratulations for ANCOM! This is a very useful and robust tool.

I am working on the development of some R packages for metagenomic data analysis and some functions depend on ANCOM. To improve the integration of ANCOM with other tools I have made some changes to the repository to convert it into an R package.

  1. Move the ancom_v2.R to R folder and add function documentation (from you repor README)
  2. Add *-sample-metadata.tsv and *-table-taxa.tsv as a package data. This helps to perform code tests. See data-raw floder.
  3. Remove out and __scripts folders
  4. Move images volder to inst/extdata folder
  5. Add R-CMD-check of the package via github actions. Checks are performed in macOS and ubuntu in multiple R versions.
  6. README simplification. It would be nice to move specific examples to vignetts in the future.

If you want to reverse or incorporate any changes I can help you. And if in the future you want to submit the package to bioconductor that would be great (I can also help you).

Bests

Francesc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant