Fix missing SecurityLevel of the EndpointDescription #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Part 4 - 7.10 this should be an a number that indicates how secure the EndPoint is. The number is Server implementation specific, how higher the number how saver.
bitkeeper
commented
Jul 10, 2023
| @@ -402,6 +402,63 @@ async def _setup_server_nodes(self): | |||
| ua.MessageSecurityMode.Sign, self.certificate, self.iserver.private_key, | |||
| permission_ruleset=self._permission_ruleset)) | |||
|
|
|||
|
|
|||
| @staticmethod | |||
| def lookup_security_level_for_policy_type( security_policy_type: ua.SecurityPolicyType ) -> ua.Byte: | |||
There was a problem hiding this comment.
Not sure if server.py is the right location for the two helper methods. The helpers are only relevant for the Server and server tests.
Maybe the there is better location in an other file with more helpers?
Considered the following locations:
uatypes:ua.SecurityPolicyTypeis implemented in there, but only contains type related stuffuacrypto: looking at the other members is doesn't belong here also
There was a problem hiding this comment.
not sure either. we just leave it here..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Part 4 - 7.10 this should be an a number that indicates how secure the EndPoint is. The current implementation used a level of 0 for every EndPoint.
The number is Server implementation specific, how higher the number how safer the security is.
See https://reference.opcfoundation.org/Core/Part4/v104/docs/7.10
Case:
Hit this issue when implementing a server which supports a GDS push application/certificate with the Ua GDS Server. Ua GDS server ignores endpoints with a security level of 0.