Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync_wrapper functions #1371

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

okapies
Copy link
Contributor

@okapies okapies commented Jul 21, 2023

Add sync_uaclient_method and sync_async_client_method to use the underlying asynchronous methods while leveraging sync.Client.

@oroulet
Copy link
Member

oroulet commented Jul 24, 2023

What issue does that code fix? I am a bit in a hurry but I could not understand.

@okapies
Copy link
Contributor Author

okapies commented Jul 24, 2023

Some functionalities of the async client (both Client and UaClient) are not implemented in the sync client. I want to use them directly combined with the thread loop run in the sync Client.

@oroulet
Copy link
Member

oroulet commented Jul 24, 2023

we can have that method in addition, but why not adding the missing methods in the sync client?

@oroulet oroulet merged commit 69ad65c into FreeOpcUa:master Jul 24, 2023
5 checks passed
@okapies okapies deleted the feature/sync-wrapper branch July 24, 2023 07:56
@okapies
Copy link
Contributor Author

okapies commented Jul 24, 2023

Thanks for the merge. Because I finally found that I need to use UaClient directly for my use cases (e.g., handling detailed statuses for each item from the OPC server while reading values) in addition to #1369 and #1370.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants