Uaerr #1669
Closed
Uaerr #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmunau
reviewed
Jul 1, 2024
| pass | ||
|
|
||
|
|
||
| class UaClientConnectionLostError(UaError): |
There was a problem hiding this comment.
Maybe have this also inherit ConnectionError for any existing code out there that excepts that?
sigmunau
reviewed
Jul 1, 2024
| @@ -531,13 +532,22 @@ async def check_connection(self) -> None: | |||
| # if not it throws the underlying exception | |||
sigmunau
reviewed
Jul 1, 2024
Comment on lines
533
to
+544
| if self._renew_channel_task is not None: | ||
| if self._renew_channel_task.done(): | ||
| await self._renew_channel_task | ||
| try: | ||
| await self._renew_channel_task | ||
| except Exception as ex: | ||
| raise UaClientRenewChannelError() from ex | ||
| if self._monitor_server_task is not None: | ||
| if self._monitor_server_task.done(): | ||
| await self._monitor_server_task | ||
| try: | ||
| await self._monitor_server_task | ||
| except Exception as ex: | ||
| raise UaClientConnectionLostError() from ex |
There was a problem hiding this comment.
Maybe change the order of these two blocks. If the monitor task determines that the connection is lost, any errors in the renew channel task is most likely due to the lost connection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.