Updating the position of the null terminator in the case for the stri…

…ng data. In the existing code, the terminator is actually overwrites the last character when the value buffer length is exactly the size of the string data + 1.
FreeRADIUS · Aug 28, 2019 · 6c56d9c · 6c56d9c
1 parent ef05709
commit 6c56d9c
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/lib/avpair.c b/lib/avpair.c
@@ -770,10 +770,7 @@ int rc_avpair_tostr (rc_handle const *rh, VALUE_PAIR *pair, char *name, int ln,
 			}
 			ptr++;
 		}
-		if (lv > 0)
-			value[pos++] = 0;
-		else
-			value[pos-1] = 0;
+		value[pos] = 0;
 		break;
 
 	    case PW_TYPE_INTEGER: