Use MBedTLS 3.5.1 #184
Use MBedTLS 3.5.1 #184
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 3 3
Lines 1689 1690 +1
Branches 442 442
=======================================
+ Hits 1588 1589 +1
Misses 17 17
Partials 84 84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…asses, some formatting tweaks, and add the coverage cop action.
…A, just going to add a log message instead. Include the mbedtls config file if defined in core_pkcs11_mbedtls.c. Change the winsock2.h include method to mirror the way it's being done in the rest of the FreeRTOS repos
| @@ -32,7 +32,7 @@ jobs: | |||
| make -C build/ all | |||
|
|
|||
| - name: Integration Tests | |||
| run: ctest --test-dir build --output-on-failure | tee -a $GITHUB_STEP_SUMMARY | |||
There was a problem hiding this comment.
Could you add the "| tee -a $GITHUB_STEP_SUMMARY" back to each of the unit test runs?
There was a problem hiding this comment.
The tee masks the exit code of the previous command. This means that the tests can actually fail, but the exit code of the tee is read marking it as a success.
Link to a run where this happened to show what I'm talking about can be seen here
-----------------------
30 Tests 1 Failures 0 Ignored
FAIL
67% tests passed, 1 tests failed out of 3
Total Test time (real) = 0.03 sec
The following tests FAILED:
3 - pkcs11_wrapper_utest (Failed)
| #include <stdio.h> | ||
| #include <string.h> | ||
|
|
||
| #ifdef WIN32 |
There was a problem hiding this comment.
Recognize that as this is the "freertos_winsim" port for this file, we shouldn't really need to check for if WIN32 is defined, just did this for if the file ever gets copied somewhere else.
Description
Use MBedTLS 3.5.1 for the corePKCS11 MBedTLS tests
Add some new checks to account for the changes
Wrap certain sections related to crypto operations in config checks
Swap the Windows port to use
WIN32_LEAN_AND_MEANandwinsock2.hfor compatibility with mbedtls v3.5.1Test Steps
Ran the FreeRTOS-Plus WinSim demos and unit tests in this repository with these changes.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.