-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SILE resilient master files #3
base: main
Are you sure you want to change the base?
Conversation
With provided settings, these compiled without crashing (but of course the results have to be checked):
Failing: ULT. It was still running so I stopped after some 3900 pages (41 MB) and it appears it contains sequences that are not encoded in USX but as raw text. That's a problem in the source USX file.
Some conversion artifacts? |
324f7fd
to
e64320c
Compare
Added French bibles...
|
5fa762d
to
2fd8494
Compare
More French:
EDIT: I am tempted to say that punctuation encoding in the source is quite lame, though. |
Greek
|
4c69d9f
to
d0d7d40
Compare
There are two books in NCS with empty headers While we could make the code not to crash, how are we going to guess the running header? |
This whole USX, USFM, USFX etc. is unsane. If supporting poorly designed XML schema (and I weight my words here) is a necessity for SILE 1.0, we are going to wait long. And I thought TEI XML was complex -- it's a pleasure compared to this... |
NCL, with a hack for missing headers = 1770 pages without any other crash. |
Interesting USX example: - It's public domain - The sheer amount of notes is a challenge
As part of this PR, I am also adding the TGCNT (Text-Critical Greek New Testament):
The latter point is interesting, as the current USX support in re·sil·ient just collates the notes in the page margin, but this is not using "true" insertions, so the amount of notes here cannot fit and overflows: There are interesting challenges here to address, and this "small" bible is a perfect use case (besides Greek being nice, heh). |
Aside note: Of course, we could use a much smaller font size and try to make all notes fit, but that wouldn't be fair ;) |
N.B. My "task" here is done -- I'll remove the "Draft" status on the PR when resilient.sile 2.2.1 is released with the fixes identified here. I'd expect this to occur by the end of 2023. |
Minimum supported versions (as of now):
Merry Christmas! |
Ping. |
Well, Bibles don't contain a lot of italicized text, but since this nice feature is now available with SILE 0.15.x, there's no reason to leave it commented out.
Since I made a quick pass on these files as part of the regression testing of resilient.sile 2.5 with SILE 0.15.5, let's take this opportunity to use these new versions and add simple book matters. The Book, after all, shall have covers, even if minimalist for now.
To paraphrase one of your own message: |
Closes #2
Work in progress,to check how good is the USX support in the re·sil·ient collection, and what needs to be fixed there:EDIT: As part of this PR, I am also adding the TGCNT, see comment.
EDIT: Issues noted in comment below addressed resilient 2.2.1.