Merge pull request #234 from FriendsOfCake/141-blacklist-lookup

feat: Blacklist Crud.LookupAction by default
FriendsOfCake · Feb 5, 2018 · df82b0f · df82b0f
2 parents 216a945 + 2d0f06f
commit df82b0f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/docs/_partials/pages/index/buttons.rst b/docs/_partials/pages/index/buttons.rst
@@ -94,6 +94,10 @@ Crud action classes are mapped but should not all be shown on the main UI.
     $action = $this->Crud->action();
     $action->config('scaffold.actions_blacklist', ['add', 'delete']);
 
+By default, we blacklist the action which is mapped to ``Crud.LookupAction``.
+As this action is meant to be used solely for autocompletion, it *cannot* be removed
+from the ``scaffold.actions_blacklist`` list.
+
 Action Groups
 ~~~~~~~~~~~~~
 

diff --git a/src/Listener/ViewListener.php b/src/Listener/ViewListener.php
@@ -479,6 +479,11 @@ protected function _getAllowedActions()
 
         $blacklist = (array)$this->_action()->getConfig('scaffold.actions_blacklist');
         $blacklist = array_combine($blacklist, $blacklist);
+        foreach ($this->_crud()->getConfig('actions') as $action => $config) {
+            if ($config['className'] === 'Crud.Lookup') {
+                $blacklist[$action] = $action;
+            }
+        }
 
         return array_diff_key($allActions, $blacklist);
     }