Allow overwriting rules in configuration

FriendsOfSymfony · Dec 22, 2018 · f467c32 · f467c32
1 parent 558b149
commit f467c32
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 1 deletion.
diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
@@ -339,7 +339,7 @@ private function addFormatListenerSection(ArrayNodeDefinition $rootNode)
                     ->children()
                         ->scalarNode('service')->defaultNull()->end()
                         ->arrayNode('rules')
-                            ->cannotBeOverwritten()
+                            ->performNoDeepMerging()
                             ->prototype('array')
                                 ->fixXmlConfig('priority', 'priorities')
                                 ->fixXmlConfig('attribute', 'attributes')

diff --git a/Tests/DependencyInjection/ConfigurationTest.php b/Tests/DependencyInjection/ConfigurationTest.php
@@ -150,6 +150,54 @@ public function testLoadBadCodesClassThrowsException()
         );
     }
 
+    public function testOverwriteFormatListenerRulesDoesNotMerge()
+    {
+        $configuration = $this->processor->processConfiguration(
+            $this->configuration,
+            [
+                [
+                    'format_listener' => [
+                        'rules' => [
+                            [
+                                'path' => '^/admin',
+                                'priorities' => ['html'],
+                            ],
+                            [
+                                'path' => '^/',
+                                'priorities' => ['html', 'json'],
+                            ],
+                        ],
+                    ],
+                ],
+                [
+                    'format_listener' => [
+                        'rules' => [
+                            [
+                                'path' => '^/',
+                                'priorities' => ['json'],
+                            ],
+                        ],
+                    ],
+                ],
+            ]
+        );
+
+        $expected = [
+            [
+                'path' => '^/',
+                'priorities' => ['json'],
+                'host' => null,
+                'methods' => null,
+                'attributes' => [],
+                'stop' => false,
+                'prefer_extension' => true,
+                'fallback_format' => 'html',
+            ],
+        ];
+
+        $this->assertEquals($expected, $configuration['format_listener']['rules']);
+    }
+
     /**
      * incorrectExceptionCodeProvider.
      *