Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable/array key usage #100

Closed
wants to merge 2 commits into from
Closed

Fix variable/array key usage #100

wants to merge 2 commits into from

Conversation

paddyhamburg
Copy link

Fixed warning if key "type" of array is empty.

benjaminfayaz
benjaminfayaz approved these changes Jun 27, 2023
View reviewed changes
Copy link

@benjaminfayaz benjaminfayaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this! 👍

@thePanz thePanz mentioned this pull request Nov 17, 2023
Merged
@thePanz
Copy link
Member

thePanz commented Nov 17, 2023

CI is stuck, not sure why 🤷
Rebased and merged in #101

Thank you all!

@thePanz thePanz closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePanz thePanz thePanz approved these changes

@thirsch thirsch thirsch approved these changes

@alquerci alquerci alquerci approved these changes

@Tybaze Tybaze Tybaze approved these changes

@benjaminfayaz benjaminfayaz benjaminfayaz approved these changes

@bencrises bencrises bencrises approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@paddyhamburg @thePanz @thirsch @alquerci @Tybaze @benjaminfayaz @bencrises