PHP 8 Deprecation - Validate length on null float/decimal #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your model contains a nullable float/decimal, and a null value is passed into the Doctrine_Validator::validateLength static method, the validator attempts to call abs on a null value, resulting in a PHP Deprecation Error:
It seems that any value with a null value should pass this validator so this PR simply returns early if the value is null.