-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix more than one record generator initialisation on same php process #55
base: master
Are you sure you want to change the base?
Conversation
…P process - Add test to avoid BC breaks when the class record can be autoloaded - Add test for table serialization with I18n behavior and its record filter - Add record post setUp event.
- Fix table serialization for record filters. - Add record post setUp event.
It seems to work on test cases but in a real usage as the generated class is not taken from cache too. All behaviours that moves columns like as I18n does not works. Such issue should be caught by tests but it seems there is something missing on the test execution. |
Indeed with the fix on the test case the bug appears. I push a quick patch for the I18n behaviour but serialized data should be frozen before setup. |
cc986a3
to
c8d8cff
Compare
…' into fix-more-than-one-record-generator-initialisation-on-same-php-process * fix-tests-to-be-able-to-finish-it-without-a-fatal-error: Fix tests to be able to finish it without a fatal error
This reverts commit c8d8cff.
What provides this patch?
sfDoctrineMasterSlavePlugin
).How the bug is going to be patched?
sfDoctrineRecordI18nFilter
)Side note
sfDoctrinePlugin
need to be fixed in consequences.tests
.Tests
Adds 6 assertions with 0 new failures.
Todo
cc @j0k3r @GromNaN