-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker images build to handle old linux distribution #90
base: master
Are you sure you want to change the base?
Conversation
f9a75e4
to
19caed4
Compare
@alquerci could you please rebase this as well? Thanks! |
19caed4
to
6781f1a
Compare
@thirsch rebased too. |
6d95fcc
to
e54cf0e
Compare
@thePanz it's rebased on master branch and ready to merge. Now the |
52985c8
to
4f8702a
Compare
4f8702a
to
3c9b688
Compare
3c9b688
to
a4c1e4d
Compare
a4c1e4d
to
bfdbca3
Compare
bfdbca3
to
0d87488
Compare
Rebased on |
1aba53a
to
d2dcf7b
Compare
@thirsch @Tybaze @thePanz Build docker images from scratch works : done it on GitHub action The |
19ef236
to
e451fe6
Compare
As we only support v7.4 or >= 8.1, we should review the docker image handling and simplify it. What about using the Linux Alpine images, and install.the extensions with APK? Another approach would be using mlocati ext installer (which triggers the compiling of the extensions, IIRC) |
@thePanz what issues do you see? Your issues will be tackle with care. My thinking There are many ways to do one thing. The purpose of this PR was to make the local development environment working. The first patch was done since more than 1 year. Working on big things does not work, big PR need too much time to review, then are hard to be merged. |
Not sure, I did not mention any issue.. I might not get your question, sorry. Yes, I noticed that this PR (and the other one for SF¹) is quite old and got a lot of work. This is remarkable the work you did here! My comment was more towards a next step, where PHP 5.3 can be removed from the docker containers, hopefully reducing the complexity in handling the setup of such versions ofn Linux. |
@thePanz yes, we can simplify it, reduce build time and more. Removing PHP 5.3 does not make a big difference, as I successfully make the alignment of PHP 5.3 docker image interface with overs. See the configuration merge done on docker-compose. The major impact of removing PHP version for docker is to reduce the build time. Where improvement exists, there is at least one issue. The issue you are talking about is the complexity of the Dockerfile. Other issues are:
|
How much faster would parallel testing be? |
No faster than the slowest test. Parallel testing, indeed, is an idea, but it is not supported now. |
I will give a try to paratest. I've never used it, I wonder how much faster it is. |
Error: the input device is not a TTY
e451fe6
to
b620436
Compare
#see FriendsOfSymfony1/symfony1#270