Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker images build to handle old linux distribution #90

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

alquerci
Copy link

@alquerci alquerci commented Nov 29, 2022

@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch from f9a75e4 to 19caed4 Compare November 29, 2022 16:02
@alquerci alquerci changed the title [WIP] Fix docker images build to handle GPG signature expiration of APT packages Fix docker images build to handle GPG signature expiration of APT packages Nov 29, 2022
@thirsch
Copy link
Collaborator

thirsch commented Jan 13, 2023

@alquerci could you please rebase this as well? Thanks!

@alquerci alquerci changed the title Fix docker images build to handle GPG signature expiration of APT packages Fix docker images build to handle old linux distribution Apr 26, 2023
@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch from 19caed4 to 6781f1a Compare April 26, 2023 21:09
@alquerci
Copy link
Author

@thirsch rebased too.

@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch 2 times, most recently from 6d95fcc to e54cf0e Compare November 19, 2023 12:14
@alquerci
Copy link
Author

alquerci commented Nov 19, 2023

@thePanz it's rebased on master branch and ready to merge.

Now the .docker directory is exactly the same as on FriendsOfSymfony1/symfony1#270

@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch 2 times, most recently from 52985c8 to 4f8702a Compare November 19, 2023 13:19
@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch from 4f8702a to 3c9b688 Compare December 14, 2023 19:38
@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch from 3c9b688 to a4c1e4d Compare December 28, 2023 22:38
@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch from a4c1e4d to bfdbca3 Compare December 30, 2023 23:18
@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch from bfdbca3 to 0d87488 Compare January 20, 2024 15:00
@alquerci
Copy link
Author

Rebased on master branch.

With fix download PHP extension from PECL without TLS

@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch 5 times, most recently from 1aba53a to d2dcf7b Compare January 20, 2024 19:34
@alquerci
Copy link
Author

@thirsch @Tybaze @thePanz Build docker images from scratch works : done it on GitHub action

The .docker directory is exactly the same on symfony1 repository on the similar PR. FriendsOfSymfony1/symfony1#270

@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch 2 times, most recently from 19ef236 to e451fe6 Compare January 23, 2024 23:26
@thePanz
Copy link
Member

thePanz commented Feb 11, 2024

As we only support v7.4 or >= 8.1, we should review the docker image handling and simplify it.

What about using the Linux Alpine images, and install.the extensions with APK? Another approach would be using mlocati ext installer (which triggers the compiling of the extensions, IIRC)

@alquerci
Copy link
Author

@thePanz what issues do you see?

Your issues will be tackle with care.


My thinking

There are many ways to do one thing.
First make it work, then make it well, then make it fast.

The purpose of this PR was to make the local development environment working.
There still need to work with more than one PHP version.

The first patch was done since more than 1 year.
I waste a lot of times maintaining it as a side branch.
I am going to be psychological tied working on it.

Working on big things does not work, big PR need too much time to review, then are hard to be merged.
However, small things, small PR can be merged more easily and frequently.
I do not want to make any more changes on this one and others I have done.

@thePanz
Copy link
Member

thePanz commented Feb 11, 2024

@thePanz what issues do you see?

Not sure, I did not mention any issue.. I might not get your question, sorry.

Yes, I noticed that this PR (and the other one for SF¹) is quite old and got a lot of work. This is remarkable the work you did here!
This work, and the other PR, helped a lot other devs too to provide fixes and opening PRs in this organisation, and this is geat!

My comment was more towards a next step, where PHP 5.3 can be removed from the docker containers, hopefully reducing the complexity in handling the setup of such versions ofn Linux.

@alquerci
Copy link
Author

alquerci commented Feb 11, 2024

@thePanz yes, we can simplify it, reduce build time and more.

Removing PHP 5.3 does not make a big difference, as I successfully make the alignment of PHP 5.3 docker image interface with overs. See the configuration merge done on docker-compose.

The major impact of removing PHP version for docker is to reduce the build time.

Where improvement exists, there is at least one issue.
But if there is no issue, making improvement is useless.


The issue you are talking about is the complexity of the Dockerfile.
I do not tackle this one yet, as I focus on make it work.

Other issues are:

  • Docker image build time
  • [sf1] Slow test suite, almost one hour to run all tests for all versions.

@connorhu
Copy link
Collaborator

[sf1] Slow test suite, almost one hour to run all tests for all versions.

How much faster would parallel testing be?

@alquerci
Copy link
Author

alquerci commented Feb 11, 2024

[sf1] Slow test suite, almost one hour to run all tests for all versions.

How much faster would parallel testing be?

No faster than the slowest test.

Parallel testing, indeed, is an idea, but it is not supported now.

@connorhu
Copy link
Collaborator

I will give a try to paratest. I've never used it, I wonder how much faster it is.

@alquerci alquerci force-pushed the fix-docker-images-build-to-handle-gpg-signature-expiration-of-apt-packages branch from e451fe6 to b620436 Compare April 8, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants