Updating github action steps to fix deprecations. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thirsch
force-pushed
the
feature/update-github-actions
branch
from
cc507f8
to
b72813d
Compare
thePanz
approved these changes
Feb 11, 2024
thePanz
approved these changes
Feb 11, 2024
| @@ -43,7 +43,7 @@ jobs: | |||
| run: composer require symfony/phpunit-bridge:^5.4 --dev --prefer-dist --no-interaction --no-progress | |||
|
|
|||
| - name: Install dependencies | |||
| uses: nick-invision/retry@v1 | |||
There was a problem hiding this comment.
Do we have the same on SF1? Not sure why using an action here 🤔
There was a problem hiding this comment.
Nope, neither in sf1 nor in doctrine1. Not sure if this is required anymore as well. Think we can drop it.
thirsch
force-pushed
the
feature/update-github-actions
branch
from
b72813d
to
023f64b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is just updating the used github action steps to fix the deprecations.