[command] allow to call symfony command from anywhere #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorhu
force-pushed
the
fix/g204-call-command-anywhere
branch
from
a9e68c0
to
a48ed19
Compare
connorhu
force-pushed
the
fix/g204-call-command-anywhere
branch
from
a48ed19
to
cfda1c8
Compare
alquerci
suggested changes
Apr 4, 2024
There was a problem hiding this comment.
LGTM, but a BC break concern.
About checkProjectExists()
As a public method, we do not know the usage of this public method.
Changing its behaviour is a BC break.
Only removing its usage, will be enough.
I suggest keeping it untouched OR use config/ProjectConfiguration.class.php like
Lines 12 to 15 in 573d579
|
This feature protects the developer during development from doing the inappropriate thing (e.g. calling cli.php in the wrong way). But on a complete system, this method is no longer relevant and as I wrote, the cwd is handled by the symfony script. There are already tools used during development which are not tested and do not work properly under certain circumstances (e.g. #341). |
connorhu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #204
What this cause?
a) cwd is set properly => nothing
b) cwd is not set properly => somewhere something cause error
But it's the caller's responsibility to make sure cwd is set properly.
The symfony command sets cwd anyway:
symfony1/lib/task/generator/skeleton/project/symfony
Line 12 in 0c9ba11