Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[command] allow to call symfony command from anywhere #367

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[command] allow to call symfony command from anywhere #367

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfda1c8
allow to call symfony command from anywhere
connorhu Apr 4, 2024
b882b01
deprecate the method
connorhu Apr 4, 2024
d93f5bd
remove deprecated method call
connorhu Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions lib/task/sfBaseTask.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,10 @@ public function getFilesystem()
}

/**
* Checks if the current directory is a symfony project directory.
*
* @return true if the current directory is a symfony project directory, false otherwise
*
* @throws sfException
* @deprecated
*/
public function checkProjectExists()
{
if (!file_exists('symfony')) {
throw new sfException('You must be in a symfony project directory.');
}

return true;
}

Expand Down Expand Up @@ -116,8 +108,6 @@ protected function doRun(sfCommandManager $commandManager, $options)
return $event->getReturnValue();
}

$this->checkProjectExists();

$requiresApplication = $commandManager->getArgumentSet()->hasArgument('application') || $commandManager->getOptionSet()->hasOption('application');
if (null === $this->configuration || ($requiresApplication && !$this->configuration instanceof sfApplicationConfiguration)) {
$application = $commandManager->getArgumentSet()->hasArgument('application') ? $commandManager->getArgumentValue('application') : ($commandManager->getOptionSet()->hasOption('application') ? $commandManager->getOptionValue('application') : null);
Expand Down