Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix APC tests and add APCu support #267

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Fix APC tests and add APCu support #267

merged 4 commits into from
Jan 3, 2024

Commits on Jan 1, 2024

  1. Fix APC cache tests 

    - Using negative TTLs to force the immediate expiration of keys, while
  convenient in tests, doesn't work consistently with APC and is an
  undocumented feature. Using a low TTL and sleep() is what guarantees
  that it works for APC. See krakjoe/apcu#184

- The setting apc.use_request_time interferes with key expiration when
  running on the CLI. Making sure it always has a sensible value for
  running the tests. See krakjoe/apcu#392
    @mentalstring
    mentalstring committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    fa379ab View commit details
    Browse the repository at this point in the history

  2. Add APCu support 

    Support for the APCu extension (through sfAPCuCache) as an alternative
to APC, which no longer works with recent versions of PHP.
    @mentalstring
    mentalstring committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    234865d View commit details
    Browse the repository at this point in the history

  3. Fix sfCacheSessionStorageTest with PHP>=7.2 

    From PHP 7.2 onward, session functions are stricter and may not work
if output/headers have already been sent out. Using output buffering
prevents this issue.
    @mentalstring
    mentalstring committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    30966ee View commit details
    Browse the repository at this point in the history

  4. Remove test dependency on APC 

    Replace the use of sfAPCCache with sfFileCache in
sfCacheSessionStorageTest so that it doesn't depend on APC being
available.
    @mentalstring
    mentalstring committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    058149b View commit details
    Browse the repository at this point in the history