fix(test): exit code of lime test -- add proof of current behaviour

.php-cs-fixer.dist.php

@@ -5,6 +5,7 @@
     ->in(__DIR__.'/lib')
     ->in(__DIR__.'/data/bin')
     ->in(__DIR__.'/test')
+    ->in(__DIR__.'/test/unit/vendor')
     ->append([__FILE__])
     // Exclude PHP classes templates/generators, which are not valid PHP files
     ->exclude('task/generator/skeleton/')
@@ -21,6 +22,9 @@
     // Exclude generated files (single files)
     ->notPath('unit/config/fixtures/sfDefineEnvironmentConfigHandler/prefix_result.php')
     ->notPath('unit/config/fixtures/sfFilterConfigHandler/result.php')
+
+    // Exclude files with expected parsing error
+    ->notPath('lime/fixtures/pass_with_one_parse_error.php')
 ;
 
 $config = new PhpCsFixer\Config();
@@ -29,6 +33,7 @@
         '@PhpCsFixer' => true,
         '@Symfony' => true,
         'array_syntax' => ['syntax' => 'short'],
+        'php_unit_method_casing' => false,
     ])
     ->setCacheFile('.cache/php-cs-fixer.cache')
     ->setFinder($finder)

lib/vendor/lime/lime.php

@@ -952,8 +952,7 @@ function lime_shutdown()
       );
 
       ob_start();
-      // see http://trac.symfony-project.org/ticket/5437 for the explanation on the weird "cd" thing
-      passthru(sprintf('cd & %s %s 2>&1', escapeshellarg($this->php_cli), escapeshellarg($test_file)), $return);
+      $return = $this->executePhpFile($test_file);
       ob_end_clean();
       unlink($test_file);
 
@@ -1123,6 +1122,20 @@ public function get_failed_files()
   {
     return isset($this->stats['failed_files']) ? $this->stats['failed_files'] : array();
   }
+
+  /**
+   * The command fails if the path to php interpreter contains spaces.
+   * The only workaround is adding a "nop" command call before the quoted command.
+   * The weird "cd &".
+   *
+   * see http://trac.symfony-project.org/ticket/5437
+   */
+  public function executePhpFile(string $phpFile): int
+  {
+    passthru(sprintf('cd & %s %s 2>&1', escapeshellarg($this->php_cli), escapeshellarg($phpFile)), $return);
+
+    return $return;
+  }
 }
 
 class lime_coverage extends lime_registration
@@ -1186,8 +1199,7 @@ public function process($files)
 EOF;
       file_put_contents($tmp_file, $tmp);
       ob_start();
-      // see http://trac.symfony-project.org/ticket/5437 for the explanation on the weird "cd" thing
-      passthru(sprintf('cd & %s %s 2>&1', escapeshellarg($this->harness->php_cli), escapeshellarg($tmp_file)), $return);
+      $return = $this->harness->executePhpFile($tmp_file);
       $retval = ob_get_clean();
 
       if (0 != $return) // test exited without success

test/unit/vendor/lime/fixtures/failed.php

@@ -0,0 +1,7 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test();
+
+$test->is(false, true);

test/unit/vendor/lime/fixtures/failed_with_plan_less_than_total.php

@@ -0,0 +1,8 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test(1);
+
+$test->is(false, true);
+$test->is(true, true);

test/unit/vendor/lime/fixtures/failed_with_plan_more_than_total.php

@@ -0,0 +1,7 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test(2);
+
+$test->is(false, true);

test/unit/vendor/lime/fixtures/pass.php

@@ -0,0 +1,7 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test();
+
+$test->is(true, true);

test/unit/vendor/lime/fixtures/pass_with_one_error.php

@@ -0,0 +1,13 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+error_reporting(E_USER_ERROR);
+
+$test = new lime_test(null, [
+    'error_reporting' => true,
+]);
+
+trigger_error('some user error message', E_USER_ERROR);
+
+$test->is(true, true);

test/unit/vendor/lime/fixtures/pass_with_one_parse_error.php

@@ -0,0 +1,7 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test();
+
+parse_error

test/unit/vendor/lime/fixtures/pass_with_one_throw_exception.php

@@ -0,0 +1,8 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test();
+
+throw new LogicException('some exception message');
+$test->is(true, true);

test/unit/vendor/lime/fixtures/pass_with_plan_less_than_total.php

@@ -0,0 +1,8 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test(1);
+
+$test->is(true, true);
+$test->is(true, true);

test/unit/vendor/lime/fixtures/pass_with_plan_more_than_total.php

@@ -0,0 +1,7 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test(2);
+
+$test->is(true, true);

test/unit/vendor/lime/fixtures/skip.php

@@ -0,0 +1,7 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test();
+
+$test->skip('some skip message');

test/unit/vendor/lime/fixtures/skip_with_plan.php

@@ -0,0 +1,7 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test($plan = 2);
+
+$test->skip('some skip message', $plan);