[TASK] Fix some more PHP 8.2 deprecation notices #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address additional PHP 8.2 deprecatn warnings related to dynamic properties.
The SVG was downloaded directly from https://fontawesome.com/icons/openid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses some additional PHP 8.2 deprecation warnings which were thrown when using the extension in Typo3 12 and PHP 8.2, due to dynamic properties that had to be declared.
So far, I haven't encountered any further deprecations related to PHP 8.2. I'll continue monitoring and will notify if any are discovered.
Additionally, for Font Awesome is not present anymore, I've exchanged the Font Awesome icon for a SVG directly downloaded from fontaswesome.com