New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to use RGB caselights as status LEDs #561

Open

teookie wants to merge 1 commit into Frix-x:main from teookie:main

teookie commented Mar 19, 2024

Modified calls to gcode macro STATUS_LED to also execute if user variable status_leds_caselight_enabled is true.

Also added variable status_leds_caselight_enabled to user variables file. If user sets this to true, then caselights will function as status LEDs. If set to false, then caselights will illuminate to their initial colors as called out in [neopixel caselight], but won't function as status LEDs.

(This is my first ever pull request on github - I hope I did it right.)


          added conditions for RGB caselights to be used as status LEDs

77a6002

Frix-x mentioned this pull request

Neopixel_caselight_enable #541

Open

Owner

Frix-x commented Mar 20, 2024

Hello thanks for the PR! There is also #541 that was open. Can you have a look and see with Benoit which option is better and it could be made into a new PR that group both of the ideas?

Collaborator

Benoitone commented Mar 21, 2024 •

edited

Loading

Hello thanks for the PR! There is also #541 that was open. Can you have a look and see with Benoit which option is better and it could be made into a new PR that group both of the ideas?

@teookie I don't understand exactly the utility of variable_status_leds_caselight_enabled in variables.cfg because if you have toolhead status_led also included, caselight (not Fcob) use also status leds macros... So I think if set to false/true nothing changes...
The only utility is if you don't have toolhead status led... So maybe the other PR is a little bit simple and don't need to add another variable in variables.cfg?

PS: if you want to have different control between caselight and tool head status LEDs, many other things need to be reworked

github-actions bot commented Apr 21, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

5 similar comments

github-actions bot commented May 21, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

github-actions bot commented Jun 21, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

github-actions bot commented Jul 21, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

github-actions bot commented Aug 21, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

github-actions bot commented Sep 22, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet