New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable case lighting with caselight_on_at_startup #563

Open

mattpolito wants to merge 4 commits into Frix-x:main from mattpolito:caselights_on_at_startup

Contributor

mattpolito commented Mar 20, 2024

Using white caselights fcob_white, only the status lights on toolhead are enabled with the caselight_on_at_startup variable set to True.

This change turns on caselights using LIGHT_ON/LIGHT_OFF macros

Collaborator

Benoitone commented Mar 21, 2024

hello, LIGHT_ON/LIGHT_OFF macros are only available when fcob_white is included and so light_enabled exist.
That's Ok like this for you because you have fcob_white AND status_leds
So, you must rework a little bit your PR to be correct:
Maybe:

[gcode_macro _INIT_LEDS]
gcode:
    {% if printer["gcode_macro _USER_VARIABLES"].status_leds_enabled or printer["gcode_macro _USER_VARIABLES"].status_leds_caselight_enabled or printer["gcode_macro _USER_VARIABLES"].light_enabled %}
        {% if printer["gcode_macro _USER_VARIABLES"].caselight_on_at_startup|default(False) %}
            {% if printer["gcode_macro _USER_VARIABLES"].light_enabled %}
                LIGHT_ON
            {% endif %}
            {% if printer["gcode_macro _USER_VARIABLES"].status_leds_enabled or printer["gcode_macro _USER_VARIABLES"].status_leds_caselight_enabled %}
                STATUS_LEDS COLOR="READY"
            {% endif %}
        {% else %}
            {% if printer["gcode_macro _USER_VARIABLES"].light_enabled %}
                LIGHT_OFF
            {% endif %}
            {% if printer["gcode_macro _USER_VARIABLES"].status_leds_enabled or printer["gcode_macro _USER_VARIABLES"].status_leds_caselight_enabled %}
                STATUS_LEDS COLOR="OFF"
            {% endif %}
        {% endif %}
    {% endif %}

Benoitone mentioned this pull request

Neopixel_caselight_enable #541

Open

Contributor Author

mattpolito commented Mar 27, 2024

@Benoitone this seems like a sane change, I can update the PR. Thanks for your input


          Enable case lighting with caselight_on_at_startup

28b2754

mattpolito force-pushed the caselights_on_at_startup branch from c165958 to 28b2754 Compare

March 27, 2024 21:06

github-actions bot commented Apr 27, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

Contributor Author

mattpolito commented Apr 28, 2024

ping


          Merge branch 'main' into caselights_on_at_startup

87e3cc6

github-actions bot commented Jun 10, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!


          Merge branch 'main' into caselights_on_at_startup

6d86a19

github-actions bot commented Jul 22, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!


          Merge branch 'main' into caselights_on_at_startup

5648fac

github-actions bot commented Aug 29, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

1 similar comment

github-actions bot commented Sep 28, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet