fix(mcu) Manta 8 EXP ribbon is misconfigured, the as the configuratio… #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n maps to the physical pin order, and not the pin names defined on the MCU, This means it breaks when used with the display. Additionally, it is a combination of EXP1 and EXP2, referring to EXP1_1# doesn't make sense if the rest of the config is referring to EXP2.
1 task
|
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. |
1 similar comment
|
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manta 8 EXP ribbon is misconfigured, the as the configuration maps to the physical pin order, and not the pin names defined on the MCU,
This means it breaks when used with the display. Additionally, it is a combination of EXP1 and EXP2, referring to EXP1_1# doesn't make sense if the rest of the config is referring to EXP2.