CI: Remove outdated steps from workflows #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of implementing better dependency autoresolution, a9d0a33 ("[IMPROVE] Better deps resolver (Frogging-Family#1138)") and ff45a43 ("proton: Enable dependency autoresolver") removed the _nomakepkg_dep_resolution_distro option from customization.cfg and proton-tkg.cfg. However, CI workflows for non-makepkg builds of Wine and Proton still expect to set this option. In addition, the workflow for Arch makepkg builds of Wine contains a workaround for Frogging-Family#237 that was obviated in part by 37ce946 ("fix pipewire-jack not providing jack2 anymore on arch linux anymore (Frogging-Family#675)") and in part by 4971465 ("makepkg: Only grab lib32 deps when _NOLIB32 is set to "false"). Update the currently maintained CI workflows to remove these outdated steps. This shouldn't affect anything, as the steps being removed were already doing nothing.
|
Looks fine to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of implementing better dependency autoresolution, a9d0a33 ("[IMPROVE] Better deps resolver (#1138)") and ff45a43 ("proton: Enable dependency autoresolver") removed the _nomakepkg_dep_resolution_distro option from customization.cfg and proton-tkg.cfg. However, CI workflows for non-makepkg builds of Wine and Proton still expect to set this option.
In addition, the workflow for Arch makepkg builds of Wine contains a workaround for #237 that was obviated in part by 37ce946 ("fix pipewire-jack not providing jack2 anymore on arch linux anymore (#675)") and in part by 4971465 ("makepkg: Only grab lib32 deps when _NOLIB32 is set to "false").
Update the currently maintained CI workflows to remove these outdated steps. This shouldn't affect anything, as the steps being removed were already doing nothing.