Add pow #48
Open
Add pow #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefiCake
force-pushed
the
deficake/sha2-pow
branch
from
0d4fc94
to
603c435
Compare
xgreenx
reviewed
Dec 10, 2023
There was a problem hiding this comment.
I still am not sure why we need PoW and what benefits it gives to us. In the end, for the user, it will be like "Wait, please X second". Automating PoW to pass is much easier than passing a captcha.
This should be enough to limit the number of active users.
The PoW works in the case of someone automated bypassing the captcha somehow. Then he can drain tokens. Plus with allowing pay for the fee in different assets, we can introduce a new faucet token that only our block producer will accept.
Comment on lines
+342
to
+427
| Extension(sessions): Extension<SharedSessions>, | ||
| Extension(pow_difficulty): Extension<Arc<u8>>, |
There was a problem hiding this comment.
You can create one structure like PoW and store all related information there
DefiCake
force-pushed
the
deficake/sha2-pow
branch
from
b6897fe
to
41a93b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45