Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use alloy-rs #106

Merged
merged 13 commits into from
Aug 29, 2024
Merged

feat: use alloy-rs #106

merged 13 commits into from
Aug 29, 2024

Conversation

MujkicA
Copy link
Contributor

@MujkicA MujkicA commented Aug 22, 2024 •
edited
Loading

Closes #89
Closes #114

This PR refactors our codebase to replace ethers-rs with alloy-rs

Key changes:

  • Blob creation: With alloy, this is managed internally, removing the need for our own implementation
  • AWS KMS Config: DefaultCredentialsChain is now used, replacing the custom credentials setup

DefaultCredentialsChain has the following resolution order:

  1. Environment variables
  2. Shared config
  3. Web Identity Tokens
  4. ECS (IAM Roles for Tasks) & General HTTP credentials
  5. EC2 IMDSv2

@MujkicA MujkicA self-assigned this Aug 22, 2024
@MujkicA MujkicA added the enhancement New feature or request label Aug 26, 2024
@MujkicA MujkicA marked this pull request as ready for review August 26, 2024 06:02
Br1ght0ne
Br1ght0ne approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, super clean migration.

hal3e
hal3e reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the awesome work. Using alloy has made the codebase so much cleaner!

co-reviewed with: @segfault-magnet

Cargo.toml Outdated Show resolved Hide resolved
committer/src/setup.rs Outdated Show resolved Hide resolved
e2e/src/kms.rs Show resolved Hide resolved
packages/eth/src/aws.rs Outdated Show resolved Hide resolved
packages/eth/src/websocket/connection.rs Outdated Show resolved Hide resolved
packages/eth/src/websocket/connection.rs Outdated Show resolved Hide resolved
@MujkicA MujkicA merged commit f98e764 into master Aug 29, 2024
7 checks passed
@MujkicA MujkicA deleted the feat/alloy-rs branch August 29, 2024 13:52
@MujkicA MujkicA restored the feat/alloy-rs branch August 29, 2024 13:53
@MujkicA MujkicA deleted the feat/alloy-rs branch August 29, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@hal3e hal3e hal3e approved these changes

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@MujkicA MujkicA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swap ethers-rs for alloy-rs KZGConfig to be loaded from static bytes
4 participants
@MujkicA @Br1ght0ne @hal3e @segfault-magnet