-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Proxy upgrade verification flow #287
base: main
Are you sure you want to change the base?
Conversation
viraj124
commented
Sep 16, 2024
•
edited
Loading
edited
- closes Implement workflow to deploy upgrades with multisig #205
This PR is published in NPM with version 0.7.0-pr-287-70 |
deployment.linkedData.factory | ||
); | ||
|
||
if (!deployment.linkedData.isProxy) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are already checking this on L20. Same can be said about L50
let localBytecode: string; | ||
if (!deployment.linkedData.isProxy) { | ||
localBytecode = await ( | ||
await hre.artifacts.readArtifact(deployment.linkedData.factory) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So instead of reading artifacts, why can't you generate the bytecode here using the factory and compare it to the deployed bytecode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that's what I have been trying to figure out but to fetch the bytecode with factory I need to do the deployment first