don't update current withdrawn amount when rate limit is reset when duration hasn't passed #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
viraj124
commented
Sep 18, 2024
viraj124
commented
- closes Hexen Audit (FUEL7-2) don't update current withdrawal amount when rate limit duration hasn't passed & the new limit amount is less than current withdrawal amount #288
|
This PR is published in NPM with version **** |
viraj124
changed the title
PraneshASP
reviewed
Sep 18, 2024
packages/solidity-contracts/contracts/fuelchain/FuelMessagePortal/v3/FuelMessagePortalV3.sol
Outdated
Show resolved
Hide resolved
PraneshASP
reviewed
Sep 18, 2024
packages/solidity-contracts/contracts/fuelchain/FuelMessagePortal/v3/FuelMessagePortalV3.sol
Outdated
Show resolved
Hide resolved
PraneshASP
reviewed
Sep 18, 2024
packages/solidity-contracts/contracts/fuelchain/FuelMessagePortal/v3/FuelMessagePortalV3.sol
Outdated
Show resolved
Hide resolved
PraneshASP
reviewed
Sep 18, 2024
packages/solidity-contracts/contracts/fuelchain/FuelMessagePortal/v3/FuelMessagePortalV3.sol
Outdated
Show resolved
Hide resolved
PraneshASP
requested changes
Sep 18, 2024
packages/solidity-contracts/contracts/messaging/gateway/FuelERC20Gateway/FuelERC20GatewayV4.sol
Outdated
Show resolved
Hide resolved
packages/solidity-contracts/contracts/fuelchain/FuelMessagePortal/v3/FuelMessagePortalV3.sol
Show resolved
Hide resolved
DefiCake
reviewed
Sep 18, 2024
packages/solidity-contracts/contracts/fuelchain/FuelMessagePortal/v3/FuelMessagePortalV3.sol
Outdated
Show resolved
Hide resolved
PraneshASP
reviewed
Sep 19, 2024
PraneshASP
previously approved these changes
Sep 19, 2024
DefiCake
reviewed
Sep 19, 2024
- closes #294 --------- Co-authored-by: Mad <[email protected]>
PraneshASP
approved these changes
Sep 20, 2024
DefiCake
approved these changes
Sep 22, 2024
DefiCake
added a commit
that referenced
this pull request
Oct 17, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @fuel-bridge/[email protected] ### Major Changes - Deploy mainnet contracts, by [@DefiCake](https://github.com/DefiCake) (See [#252](#252)) ### Minor Changes - Upgrade testnet and devnet artifacts, by [@DefiCake](https://github.com/DefiCake) (See [#284](#284)) - Add rate limit status check for FuelMessagePortal, by [@DefiCake](https://github.com/DefiCake) (See [#316](#316)) - don't update current withdrawn amount when rate limit is reset, by [@viraj124](https://github.com/viraj124) (See [#290](#290)) - update comment, by [@viraj124](https://github.com/viraj124) (See [#304](#304)) - add zero address check for time to finalise, by [@viraj124](https://github.com/viraj124) (See [#306](#306)) - ci proxy upgrade verification flow, by [@viraj124](https://github.com/viraj124) (See [#287](#287)) - add rate limit disabling/re-enabling, by [@viraj124](https://github.com/viraj124) (See [#311](#311)) - 🐞 Fix upgradability: reduce FuelERC20GatewayV4 \_\_gap variable, by [@DefiCake](https://github.com/DefiCake) (See [#318](#318)) - update naming convention for immutable var, by [@viraj124](https://github.com/viraj124) (See [#314](#314)) ### Patch Changes - Added base asset deploy script and documentation, by [@DefiCake](https://github.com/DefiCake) (See [#322](#322)) - Updated testnet deployment artifacts, by [@DefiCake](https://github.com/DefiCake) (See [#326](#326)) - Swap symbol and name in the metadata payload, by [@DefiCake](https://github.com/DefiCake) (See [#313](#313)) ## @fuel-bridge/[email protected] ### Minor Changes - Upgraded forc to 0.64.0, by [@DefiCake](https://github.com/DefiCake) (See [#320](#320)) - Updated sway contracts compiler to forc v0.63.4, by [@DefiCake](https://github.com/DefiCake) (See [#282](#282)) ## @fuel-bridge/[email protected] ### Minor Changes - Improve sway scripts, by [@DefiCake](https://github.com/DefiCake) (See [#280](#280)) - integrate fork tokens in e2e test, by [@viraj124](https://github.com/viraj124) (See [#267](#267)) ## @fuel-bridge/[email protected] ### Patch Changes - Added base asset deploy script and documentation, by [@DefiCake](https://github.com/DefiCake) (See [#322](#322)) --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: DefiCake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.