feat: build ARM and AMD in parallel #2130
Conversation
mchristopher
added
the
no changelog
mchristopher
force-pushed
the
parallel-builds
branch
from
967c149
to
90bd053
Compare
mchristopher
force-pushed
the
parallel-builds
branch
from
e0946be
to
a0827b5
Compare
| - verifications-complete | ||
| runs-on: buildjet-4vcpu-ubuntu-2204 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
@Voxelot Do we want to use buildjet or switch back to github runners?
There was a problem hiding this comment.
we should probably stick with buildjet for CI performance reasons
There was a problem hiding this comment.
FYI, this moves back to basic runners for tasks that are not CPU or memory intensive (like downloading/uploading files). It's an optimization to make sure we're not spending more money than needed on buildjet.
| && xx-verify ./target/$(xx-cargo --print-target-triple)/release/fuel-core \ | ||
| && mv ./target/$(xx-cargo --print-target-triple)/release/fuel-core ./target/release/fuel-core \ | ||
| && mv ./target/$(xx-cargo --print-target-triple)/release/fuel-core.d ./target/release/fuel-core.d | ||
| && cp ./target/$(xx-cargo --print-target-triple)/release/fuel-core /root/fuel-core \ |
There was a problem hiding this comment.
Why do we want to copy if moving is faster?=)
There was a problem hiding this comment.
mv just changes the filesystem pointer, which is problematic when the build directory is cached. The cache is only mounted during this RUN command, so I need to copy the file to ensure it's available for Docker to copy to another image later in the run.
Description
Building the ARM and AMD Docker images using native runners in parallel. This will greatly speed up the CI runtime.
Before requesting review