-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use single heavy input in the transaction_throughput.rs
benchmarks
#2205
base: master
Are you sure you want to change the base?
Use single heavy input in the transaction_throughput.rs
benchmarks
#2205
Conversation
…se-single-heavy-input
…se-single-heavy-input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions from me but otherwise this looks good.
tx.estimate_predicates(&checked_parameters(), MemoryInstance::new()) | ||
.expect("Predicate check failed"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of estimating the predicates here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use predicate instead. We use one signed coin along with one predicate. All benchmarks now use at least one predicate that returns true
. The second input is different and the name reflects it
.finalize(); | ||
tx.estimate_predicates(&checked_parameters(), MemoryInstance::new()) | ||
.expect("Predicate check failed"); | ||
tx | ||
}; | ||
bench_txs("signed transfers", c, generator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename this to "predicate transfer" now when we use a predicate instead of a signed coin input?
…se-single-heavy-input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…se-single-heavy-input
…se-single-heavy-input
…se-single-heavy-input
…se-single-heavy-input
@SilentCicero
Before requesting review