Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Txpool v2 features for futures connections with other modules #2216

Draft
wants to merge 18 commits into
base: txpool-v2-api
Choose a base branch
from

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Sep 18, 2024

REVIEWER NOTE: Review #2193 first for context

Linked Issues/PRs

Closes #2187

Description

Block producer

Existing New
select_transactions(max_gas) select_transactions(max_gas)

PoA

Existing New
total_consumable_gas() Nothing (unused)
transaction_status_events() Replaced by new_txs_notifier reason
pending_number() Not used anymore after transaction_status_events() change
remove_txs() Can be remove because it's used to delete transactions that are already deleted

Block Importer

Existing New
Stream with blockEvents Stream with block events

P2P

Existing New
gossiped_tx_stream tx_from_p2p_stream
new_tx_gossip_subscription new_peers_subscribed_stream
broadcast_transaction broadcast_transaction
get_tx_ids get_tx_ids
get_txs get_txs
notify_gossip_transaction_validity notify_gossip_transaction_validity

GraphQL API

Existing New
transaction transaction
tx_update_subscribe tx_update_subscribe

Also add TTL management

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT changed the base branch from master to txpool-v2-api September 18, 2024 12:42
@AurelienFT AurelienFT self-assigned this Sep 18, 2024
@AurelienFT AurelienFT marked this pull request as ready for review September 19, 2024 12:58
@AurelienFT AurelienFT changed the title Txpool v2 features for others modules Txpool v2 features for futures connections with other modules Sep 19, 2024
@AurelienFT AurelienFT mentioned this pull request Sep 20, 2024
5 tasks
AurelienFT and others added 6 commits September 20, 2024 11:12
REVIEWER NOTE: Review #2216
first for context

## Description
Add the TTL management for transactions

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [ ] I have reviewed the code myself
- [ ] I have created follow-up issues caused by this PR and linked them
here
@AurelienFT AurelienFT marked this pull request as draft September 23, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant