Executor: test Tx_count limit with incorrect tx source #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerone85
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
xgreenx
reviewed
Sep 24, 2024
crates/fuel-core/src/executor.rs
Outdated
| /// that should be returned by [`TransactionsSource::next()`]. | ||
| /// It is used only for testing purposes | ||
| pub struct BadTransactionsSource { | ||
| transactions: Mutex<RefCell<Vec<MaybeCheckedTransaction>>>, |
There was a problem hiding this comment.
You either need to use RefCell or Mutex=D Both is too much=D
There was a problem hiding this comment.
Ah yes, I can access the data as mutable from the Lock, my bad. Fixed in 8d5e04c
xgreenx
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Closes #2225
Description
As per discussion, we should check that the current Executor logic is resilient against transactions source that ignore the limit on MAX_TX_COUNT.
Checklist
Before requesting review