Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump escrow #677

Merged
merged 22 commits into from
Jul 24, 2023
Merged

Bump escrow #677

merged 22 commits into from
Jul 24, 2023

Conversation

K1-R1
Copy link
Member

@K1-R1 K1-R1 commented May 20, 2023 •
edited
Loading

Type of change

  • Improvement (refactoring, restructuring repository, cleaning tech debt, ...)
  • Documentation

Changes

The following changes have been made:

  • Bump application to forc 0.42.1 and fuel-core 0.18.3
  • Bump test harness to fuels 0.42.0

Related Issues

Closes #654
Closes #441
Closes #443

@K1-R1 K1-R1 added App: Escrow Label used to filter for the app issue Repo Misc General repository upkeep labels May 20, 2023
@K1-R1 K1-R1 self-assigned this May 20, 2023
@K1-R1 K1-R1 marked this pull request as ready for review July 10, 2023 14:40
@K1-R1 K1-R1 requested a review from a team as a code owner July 10, 2023 14:40
@K1-R1 K1-R1 linked an issue Jul 20, 2023 that may be closed by this pull request
Bump escrow #654
Closed
@K1-R1 K1-R1 requested a review from a team July 20, 2023 21:13
Braqzen
Braqzen reviewed Jul 23, 2023
View reviewed changes
Copy link
Contributor

@Braqzen Braqzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the DAO, remove rand and use AssetId::from() to create a static value

escrow/project/contracts/escrow-contract/tests/functions/core/resolve_dispute.rs Show resolved Hide resolved
@K1-R1 K1-R1 requested a review from a team July 24, 2023 14:56
@K1-R1 K1-R1 enabled auto-merge July 24, 2023 15:02
This was referenced Jul 24, 2023
Closed
Closed
Closed
@K1-R1 K1-R1 merged commit 8a16b4a into staging-bump Jul 24, 2023
17 checks passed
@K1-R1 K1-R1 deleted the K1-R1/bump-escrow branch July 24, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Braqzen Braqzen Braqzen approved these changes

Assignees

@K1-R1 K1-R1

Labels
App: Escrow Label used to filter for the app issue Repo Misc General repository upkeep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump escrow
2 participants
@K1-R1 @Braqzen