-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix code snippet for old diagnostics #6507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdankel
reviewed
Sep 9, 2024
test/src/e2e_vm_tests/test_programs/should_fail/type_check_analyze_errors/stdout.snap
Outdated
Show resolved
Hide resolved
IGI-111
previously approved these changes
Sep 10, 2024
alfiedotwtf
reviewed
Sep 11, 2024
xunilrj
force-pushed
the
xunilrj/fix-old-diag-snippet
branch
from
September 12, 2024 11:45
510658c
to
5ae21e6
Compare
xunilrj
force-pushed
the
xunilrj/fix-old-diag-snippet
branch
from
September 16, 2024 10:47
5ae21e6
to
32e51c2
Compare
Just thinking, maybe a few simple tests that do the happy path and also bounds checks might be worth it so we don't introduce unwanted behaviour? |
xunilrj
force-pushed
the
xunilrj/fix-old-diag-snippet
branch
from
September 20, 2024 14:08
32e51c2
to
75cd7e9
Compare
I have changed the algorithm to something easier to understand, more performant, given that we iterate the string only once, and I have also written more tests. |
IGI-111
previously approved these changes
Sep 23, 2024
JoshuaBatty
previously approved these changes
Sep 24, 2024
xunilrj
force-pushed
the
xunilrj/fix-old-diag-snippet
branch
from
September 24, 2024 11:57
75e6ded
to
f1a28d3
Compare
JoshuaBatty
approved these changes
Sep 25, 2024
alfiedotwtf
reviewed
Sep 25, 2024
IGI-111
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves a small bug when calculating the code snippets of some diagnostics.
Checklist
Breaking*
orNew Feature
labels where relevant.