refactor: sign transacitons with ForcClientAccounts instead of raw sdk wallets #6577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
added
enhancement
kayagokalp
changed the title
alfiedotwtf
reviewed
Sep 23, 2024
| .await?; | ||
|
|
||
| account.add_witnesses(&mut tb)?; |
There was a problem hiding this comment.
Will add_witnesses() need to be added to ForcClientAccount? Because AFAIC the default implementation is a NOP.
Edit: sorry, I just noticed this is in draft. Ignore this comment 😅
|
closing this in favor of #6578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #6559 in preparation for #6560. Basically rather than using sdk wallet directly we are adding a level of indirection so that we can support different signers such as kms solutions that will come after this one.